Issue 20701002: Add Timeout to FF status.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20701002: Add Timeout to FF status. (Closed)

Created:
7 years, 4 months ago by floitsch

Modified:
7 years, 4 months ago

Reviewers:
ricow1, kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Add Timeout to FF status. On my machine (FF 22) it doesn't even take 5 secs to finish... R=kustermann@google.com, ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=25518

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	tests/lib/lib.status	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

ricow1

LGTM, could we increase the priority of the bug, this will take up considerable cycle ...

7 years, 4 months ago (2013-07-26 10:35:45 UTC) #2

floitsch

PTAL. I added the other test that is timing out. Also removed the "Slow" (since ...

7 years, 4 months ago (2013-07-26 11:22:30 UTC) #3

floitsch

7 years, 4 months ago (2013-07-26 11:29:47 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r25518 (presubmit successful).