Ensure warnings are given on logical boolean expressions and for loops where booleans are expected …

Ensure warnings are given on logical boolean expressions and for loops where booleans are expected but the type is not bool.

R=brianwilkerson@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34260

[gbracha, 2014-03-20 22:57:13]

A couple of missing warnings, and slight refactor of the grammar for top level
getters. Minor tweaks otherwise.

[Brian Wilkerson, 2014-03-20 23:25:25]

LGTM

[Lasse Reichstein Nielsen, 2014-03-21 08:28:59]

lgtm

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:1348: Note that a parameter that is not used in
an superexpression that is restricted to certain types can be a constant of any
type. For example}
Long sentence. Add comma after "certain types"?

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:1910: \item A type parameter cannot be used as a
superclass or superinterface (\ref{superclasses}, \ref{superinterfaces},
\ref{interfaceSuperinterfaces}).
Or a mixin?

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:1911: \item A type parameter cannot be used as a
generic.
A generic what? "Generic" is generally used as an adjective in this spec. It's
not clear what it means as a noun.

[gbracha, 2014-03-21 17:42:04]

Committed patchset #1 manually as r34260 (presubmit successful).

[gbracha, 2014-03-21 21:53:23]

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:1910: \item A type parameter cannot be used as a
superclass or superinterface (\ref{superclasses}, \ref{superinterfaces},
\ref{interfaceSuperinterfaces}).
On 2014/03/21 08:29:00, Lasse Reichstein Nielsen wrote:
> Or a mixin?

That is always implied. A mixin always acts as a superclass.

https://codereview.chromium.org/206883003/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:1911: \item A type parameter cannot be used as a
generic.
On 2014/03/21 08:29:00, Lasse Reichstein Nielsen wrote:
> A generic what? "Generic" is generally used as an adjective in this spec. It's
> not clear what it means as a noun.

I'll add 'class" in the next rev.