Changes required for ECMA standardization, plus allow void in getter return type.

Changes required for ECMA standardization, plus allow void in getter return type.

R=ahe@google.com, lrn@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34201

[gbracha, 2014-03-20 18:32:14]

Ignore all the ECMA boilerplate. The change is allowing returnType on
getterSignature.

[Brian Wilkerson, 2014-03-20 18:41:18]

https://codereview.chromium.org/206743002/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206743002/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3909: \DEFERRED;
Does this need "{}" like everything else in this list?

https://codereview.chromium.org/206743002/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3911: \ENUM{};
'enum' is currently a keyword. Should it be removed from the list of keywords,
or not added here?

[ahe, 2014-03-20 18:49:08]

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:883: returnType? \GET{} identifier
This line LGTM

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:903: It is a static warning if the return type of
a getter is \VOID.
This line LGTM.

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:3912: \ENUM{};
Did you intend to include these changes?

[gbracha, 2014-03-20 18:51:57]

https://codereview.chromium.org/206743002/diff/1/docs/language/dartLangSpec.tex
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206743002/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3909: \DEFERRED;
On 2014/03/20 18:41:18, Brian Wilkerson wrote:
> Does this need "{}" like everything else in this list?

Actually, none of them do. But I changed it to be uniform. Without the {}, the
space after the keyword is eaten up so I tend to use it uniformly as defensive
measure.

https://codereview.chromium.org/206743002/diff/1/docs/language/dartLangSpec.t...
docs/language/dartLangSpec.tex:3911: \ENUM{};
On 2014/03/20 18:41:18, Brian Wilkerson wrote:
> 'enum' is currently a keyword. Should it be removed from the list of keywords,
> or not added here?

Oops. Good catch. It can stay as a keyword.

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:3912: \ENUM{};
On 2014/03/20 18:49:09, ahe wrote:
> Did you intend to include these changes?

It turns out enum is unnecessary since it is already a reserved word. As for
deferred, yes. The TC52 meeting agreed to put it in in support of the coming
deferred loading feature.

[ahe, 2014-03-20 18:56:01]

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:3912: \ENUM{};
On 2014/03/20 18:51:58, gbracha wrote:
> On 2014/03/20 18:49:09, ahe wrote:
> > Did you intend to include these changes?
> 
> It turns out enum is unnecessary since it is already a reserved word. As for
> deferred, yes. The TC52 meeting agreed to put it in in support of the coming
> deferred loading feature.

These lines also LGTM, then :-)

[Lasse Reichstein Nielsen, 2014-03-20 20:10:33]

LGTM

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
File docs/language/dartLangSpec.tex (right):

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:903: It is a static warning if the return type of
a getter is \VOID.
Is it necessary?
It will be a static warning if the result of the getter is used (like for void
return functions). 

Not giving a warning here would allow people to use getters as nullary functions
(i.e., for the side effect only), and only warn if the result is used. Do we
want to discourage that?

https://codereview.chromium.org/206743002/diff/20001/docs/language/dartLangSp...
docs/language/dartLangSpec.tex:4884: returnType? getOrSet identifier
formalParameterList functionBody;
This getter/setter production is unlike all the other cases. It seems to allow a
formalParameterList for a getter.

How about changing it to two productions:
     returnType? \GET identifier functionBody;
     returnType? \SET identifier formalParameterList functionBody;

(I don't think getOrSet is used anywhere else).

[gbracha, 2014-03-20 20:23:45]

Committed patchset #3 manually as r34201 (presubmit successful).