Trace.current skips an extra frame in JS.

Trace.current skips an extra frame in JS.

JS traces include a frame for StackTrace.current while VM traces do not.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/stack_trace/commit/9da091043b8f6aba2d11c836c9698d5b0241d7e4

[nweiz, 2016-06-14 22:01:45]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[kevmoo, 2016-06-14 22:35:12]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-06-14 22:35:13]

DBC

https://codereview.chromium.org/2067063002/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/2067063002/diff/1/lib/src/utils.dart#newcode13
lib/src/utils.dart:13: final bool inJS = p.style == p.Style.url;
Could this cause problems for VM files loaded via HTTP? (i.e. pub, pub run, etc)

[nweiz, 2016-06-14 22:54:56]

https://codereview.chromium.org/2067063002/diff/1/lib/src/utils.dart
File lib/src/utils.dart (right):

https://codereview.chromium.org/2067063002/diff/1/lib/src/utils.dart#newcode13
lib/src/utils.dart:13: final bool inJS = p.style == p.Style.url;
On 2016/06/14 22:35:13, kevmoo wrote:
> Could this cause problems for VM files loaded via HTTP? (i.e. pub, pub run,
etc)

The URL that Dart code is loaded from doesn't affect Uri.base.

[Bob Nystrom, 2016-06-14 23:22:36]

lgtm

[nweiz, 2016-06-14 23:23:22]

Description was changed from

==========
Trace.current skips an extra frame in JS.

JS traces include a frame for StackTrace.current while VM traces do not.
==========

to

==========
Trace.current skips an extra frame in JS.

JS traces include a frame for StackTrace.current while VM traces do not.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/stack_trace/commit/9da091043b8f6aba2d11c836c9698...
==========

[nweiz, 2016-06-14 23:23:25]

Committed patchset #1 (id:1) manually as
9da091043b8f6aba2d11c836c9698d5b0241d7e4 (presubmit successful).