Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 206623010: Add support for ie11 in our testing scripts (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add support for ie11 in our testing scripts We explicitly need this since we need to be able to distinguesh between the different versions in the status files. We could generalize this by having browser groups for everything but the actual status file parsing. Committed: https://code.google.com/p/dart/source/detail?r=34349

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M tools/testing/dart/browser_controller.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tools/testing/dart/runtime_configuration.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 3 chunks +5 lines, -4 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ricow1
6 years, 9 months ago (2014-03-25 08:46:58 UTC) #1
ricow1
TBR
6 years, 9 months ago (2014-03-25 08:51:45 UTC) #2
ricow1
Committed patchset #1 manually as r34349 (presubmit successful).
6 years, 9 months ago (2014-03-25 08:51:59 UTC) #3
Bill Hesse
6 years, 9 months ago (2014-03-25 09:00:56 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698