Add location information to the JSON reporter.

Add location information to the JSON reporter.

Closes #420

Committed: https://github.com/dart-lang/test/commit/62cf174635490fe58b4d7e371f1bb3accbf333f7

[nweiz, 2016-06-14 22:53:02]

nweiz@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-06-15 19:50:38]

https://codereview.chromium.org/2066113002/diff/40001/lib/src/runner/reporter...
File lib/src/runner/reporter/json.dart (right):

https://codereview.chromium.org/2066113002/diff/40001/lib/src/runner/reporter...
lib/src/runner/reporter/json.dart:268: GroupEntry entry, TestPlatform platform)
{
no import for `TestPlatform` class

https://codereview.chromium.org/2066113002/diff/40001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2066113002/diff/40001/pubspec.yaml#newcode39
pubspec.yaml:39: dependency_overrides:
published now, right?

Might could update the dependency on stack_trace? To ensure everything works
correctly

https://codereview.chromium.org/2066113002/diff/40001/test/runner/json_report...
File test/runner/json_reporter_test.dart (right):

https://codereview.chromium.org/2066113002/diff/40001/test/runner/json_report...
test/runner/json_reporter_test.dart:568: line == null ? null :
p.toUri(p.join(sandbox, "test.dart")).toString()
Tests that validate the url (including below) fail on mac

You need to update`createTempDir()` in `util/io.dart` to return a directory with
symbolic links resolved.

On Mac, I get file:///var/folders/
mapped to file:///private/var/folders/

```
/// Creates a temporary directory and returns its path.
String createTempDir() =>
    new
Directory(_tempDir).createTempSync('dart_test_').resolveSymbolicLinksSync();
```

[nweiz, 2016-06-15 20:35:39]

https://codereview.chromium.org/2066113002/diff/40001/lib/src/runner/reporter...
File lib/src/runner/reporter/json.dart (right):

https://codereview.chromium.org/2066113002/diff/40001/lib/src/runner/reporter...
lib/src/runner/reporter/json.dart:268: GroupEntry entry, TestPlatform platform)
{
On 2016/06/15 19:50:38, kevmoo wrote:
> no import for `TestPlatform` class

Done.

https://codereview.chromium.org/2066113002/diff/40001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2066113002/diff/40001/pubspec.yaml#newcode39
pubspec.yaml:39: dependency_overrides:
On 2016/06/15 19:50:38, kevmoo wrote:
> published now, right?

Done.

> Might could update the dependency on stack_trace? To ensure everything works
> correctly

I don't really like incrementing dependency versions for bug fixes. Even if the
bug fix is helpful to some part of test, it'll still work okay without it.

https://codereview.chromium.org/2066113002/diff/40001/test/runner/json_report...
File test/runner/json_reporter_test.dart (right):

https://codereview.chromium.org/2066113002/diff/40001/test/runner/json_report...
test/runner/json_reporter_test.dart:568: line == null ? null :
p.toUri(p.join(sandbox, "test.dart")).toString()
On 2016/06/15 19:50:38, kevmoo wrote:
> Tests that validate the url (including below) fail on mac
> 
> You need to update`createTempDir()` in `util/io.dart` to return a directory
with
> symbolic links resolved.
> 
> On Mac, I get file:///var/folders/
> mapped to file:///private/var/folders/
> 
> ```
> /// Creates a temporary directory and returns its path.
> String createTempDir() =>
>     new
> Directory(_tempDir).createTempSync('dart_test_').resolveSymbolicLinksSync();
> ```

Uggggh, I hate Mac OS's crazy symlinks. Glad you caught this, though.

[nweiz, 2016-06-15 20:36:09]

Description was changed from

==========
Add location information to the JSON reporter.

Closes #420
==========

to

==========
Add location information to the JSON reporter.

Closes #420

Committed:
https://github.com/dart-lang/test/commit/62cf174635490fe58b4d7e371f1bb3accbf3...
==========

[nweiz, 2016-06-15 20:36:11]

Committed patchset #4 (id:60001) manually as
62cf174635490fe58b4d7e371f1bb3accbf333f7 (presubmit successful).