Issue 20654003: Mark a Dartium test as flaky until the corresponding issue is resolved.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20654003: Mark a Dartium test as flaky until the corresponding issue is resolved. (Closed)

Created:
7 years, 4 months ago by Florian Schneider

Modified:
7 years, 4 months ago

Reviewers:
ricow1

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark a Dartium test as flaky until the corresponding issue is resolved. BUG=dart:12177 Committed: https://code.google.com/p/dart/source/detail?r=25710

Patch Set 1 #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	pkg/pkg.status	View		1 chunk	+1 line, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Florian Schneider

Committed patchset #1 manually as r25710 (presubmit successful).

7 years, 4 months ago (2013-08-01 15:55:39 UTC) #2

ricow1

7 years, 4 months ago (2013-08-01 15:55:42 UTC) #3

Message was sent while issue was closed.

LGTM if you put it under another section

https://codereview.chromium.org/20654003/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/20654003/diff/1/pkg/pkg.status#newcode169
pkg/pkg.status:169: [ $runtime == dartium || $runtime == drt ]
I think you need to put it under a
[ $compiler == none && ($runtime == drt || $runtime == dartium) ]

otherwise this will also mark it as flaky on chrome linux

Expand Messages | Collapse Messages