Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 20631002: [pkg:observe] Add support for explicit change notification, even on dirty-checked objects (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly
Modified:
7 years, 5 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

[pkg:observe] Add support for explicit change notification, even on dirty-checked objects. This is to fix warnings in Polymer.dart's TodoMVC example. Even though the objects extend ObservableMixin, they still have some computed fields that they notify manually. This seems like a scenario we should support, WDYT? Also fixed a TODO about sending an unmodifiable list to the stream. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=25531

Patch Set 1 #

Patch Set 2 : revert pubspec #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -36 lines) Patch
M pkg/observe/lib/src/change_notifier.dart View 4 chunks +7 lines, -27 lines 0 comments Download
M pkg/observe/lib/src/observable.dart View 4 chunks +63 lines, -9 lines 2 comments Download
M pkg/observe/test/observe_test.dart View 1 chunk +43 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jennifer Messerly
7 years, 5 months ago (2013-07-26 02:02:30 UTC) #1
Siggi Cherem (dart-lang)
lgtm! https://codereview.chromium.org/20631002/diff/2001/pkg/observe/lib/src/observable.dart File pkg/observe/lib/src/observable.dart (right): https://codereview.chromium.org/20631002/diff/2001/pkg/observe/lib/src/observable.dart#newcode149 pkg/observe/lib/src/observable.dart:149: // Start with an manually notified records (computed ...
7 years, 5 months ago (2013-07-26 15:53:14 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/20631002/diff/2001/pkg/observe/lib/src/observable.dart File pkg/observe/lib/src/observable.dart (right): https://codereview.chromium.org/20631002/diff/2001/pkg/observe/lib/src/observable.dart#newcode149 pkg/observe/lib/src/observable.dart:149: // Start with an manually notified records (computed properties, ...
7 years, 5 months ago (2013-07-26 18:14:43 UTC) #3
Jennifer Messerly
7 years, 5 months ago (2013-07-26 18:15:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25531 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698