Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 206293002: Rename src-tarball to linux-distribution-support (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename src-tarball to linux-distribution-support I will follow up with the corresponding buildbot cl R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34160

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -95 lines) Patch
M client/tools/buildbot_annotated_steps.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
A + tools/bots/linux_distribution_support.py View 1 1 chunk +1 line, -1 line 0 comments Download
D tools/bots/src-tarball.py View 1 chunk +0 lines, -92 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 9 months ago (2014-03-20 10:31:08 UTC) #1
Søren Gjesse
lgtm, but shouldn't we stich to unserscores in python file names?
6 years, 9 months ago (2014-03-20 10:38:59 UTC) #2
ricow1
6 years, 9 months ago (2014-03-20 10:42:43 UTC) #3
ricow1
Updated with python file using underscores
6 years, 9 months ago (2014-03-20 10:42:52 UTC) #4
ricow1
6 years, 9 months ago (2014-03-20 10:43:13 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r34160 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698