Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(301)

Issue 206263005: Add debug-printing to file, and remove from test. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Add debug-printing to file, and remove from test. Adding the debug print made the test stop failing. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34168

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -10 lines) Patch
M pkg/docgen/test/generate_json_test.dart View 1 chunk +1 line, -9 lines 0 comments Download
M runtime/bin/file.cc View 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-20 14:22:44 UTC) #1
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-20 14:23:55 UTC) #2
Anders Johnsen
6 years, 9 months ago (2014-03-20 14:24:26 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34168 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698