Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 206213004: Add a VM page to the observatory. (Closed)

Created:
6 years, 9 months ago by turnidge
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Add a VM page to the observatory. Make the VM a ServiceObject. Some refactoring in the ServiceObject implementation. IsolateList is no longer a ServiceObject. It should eventually become more like our caches. Support the /vm request in the vm. Remove isolate list request. Improvements to Isolate::PrintToJSONStream: always provide a reasonable name. Use the same code to produce isolate refs and non-refs. Improve isolate status message when the isolate is paused at start/exit. Add a resume link to the isolate view. Add a navbar to the error page so that dartium users are less likely to get stuck. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34204

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : before review #

Total comments: 6

Patch Set 4 : js / tests #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3603 lines, -2927 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 12 chunks +99 lines, -30 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 414 chunks +1449 lines, -1281 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 12 chunks +99 lines, -30 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 414 chunks +1449 lines, -1281 lines 0 comments Download
M runtime/bin/vmservice/client/lib/elements.dart View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/elements.html View 2 chunks +2 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/app/application.dart View 1 2 1 chunk +5 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/app/location_manager.dart View 1 2 3 chunks +13 lines, -43 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/error_view.html View 2 chunks +6 lines, -1 line 0 comments Download
D runtime/bin/vmservice/client/lib/src/elements/isolate_list.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D runtime/bin/vmservice/client/lib/src/elements/isolate_list.html View 1 chunk +0 lines, -22 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_summary.html View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.dart View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_view.html View 5 chunks +21 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/nav_bar.html View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/observatory_element.dart View 1 2 3 2 chunks +29 lines, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.dart View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/service_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
A + runtime/bin/vmservice/client/lib/src/elements/vm_ref.dart View 1 chunk +4 lines, -4 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/elements/vm_ref.html View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
A + runtime/bin/vmservice/client/lib/src/elements/vm_view.dart View 1 chunk +11 lines, -9 lines 0 comments Download
A runtime/bin/vmservice/client/lib/src/elements/vm_view.html View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/cache.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 2 3 14 chunks +153 lines, -63 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/service.dart View 2 chunks +8 lines, -4 lines 0 comments Download
M runtime/vm/isolate.h View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/isolate.cc View 1 2 3 4 2 chunks +22 lines, -8 lines 0 comments Download
M runtime/vm/json_stream.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/service.h View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/vm/service.cc View 1 2 3 4 6 chunks +47 lines, -15 lines 0 comments Download
M runtime/vm/service/running_isolates.dart View 1 chunk +3 lines, -20 lines 0 comments Download
M runtime/vm/service_test.cc View 1 2 3 4 2 chunks +7 lines, -3 lines 0 comments Download
M tests/standalone/vmservice/isolate_bad_class_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_bad_object_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_class_field_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_class_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_code_test.dart View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M tests/standalone/vmservice/isolate_echo_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_function_test.dart View 1 2 3 4 1 chunk +5 lines, -5 lines 0 comments Download
M tests/standalone/vmservice/isolate_library_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_list_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/isolate_stacktrace_command_test.dart View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/vmservice/multiple_isolate_list_test.dart View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 1 2 3 4 3 chunks +9 lines, -9 lines 0 comments Download
M tests/standalone/vmservice/unknown_isolate_command_test.dart View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/vmservice/websocket_client_test.dart View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
6 years, 9 months ago (2014-03-20 16:49:40 UTC) #1
Cutch
lgtm with comments https://codereview.chromium.org/206213004/diff/40001/runtime/bin/vmservice/client/lib/elements.dart File runtime/bin/vmservice/client/lib/elements.dart (right): https://codereview.chromium.org/206213004/diff/40001/runtime/bin/vmservice/client/lib/elements.dart#newcode39 runtime/bin/vmservice/client/lib/elements.dart:39: export 'package:observatory/src/elements/vm_view.dart'; blank line at end? ...
6 years, 9 months ago (2014-03-20 18:25:56 UTC) #2
turnidge
https://codereview.chromium.org/206213004/diff/40001/runtime/bin/vmservice/client/lib/elements.dart File runtime/bin/vmservice/client/lib/elements.dart (right): https://codereview.chromium.org/206213004/diff/40001/runtime/bin/vmservice/client/lib/elements.dart#newcode39 runtime/bin/vmservice/client/lib/elements.dart:39: export 'package:observatory/src/elements/vm_view.dart'; On 2014/03/20 18:25:56, Cutch wrote: > blank ...
6 years, 9 months ago (2014-03-20 19:08:02 UTC) #3
turnidge
6 years, 9 months ago (2014-03-20 21:00:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r34204 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698