Issue 2061383003: Fix NSME when file contents cannot be read (#260).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2061383003: Fix NSME when file contents cannot be read (#260). (Closed)

Created:
4 years, 6 months ago by pquitslund

Modified:
4 years, 6 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/linter.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -4 lines)			Patch
	M	lib/src/formatter.dart	View	1	1 chunk	+9 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Brian Wilkerson

Assuming the StateError will be caught and dealt with appropriately, lgtm

4 years, 6 months ago (2016-06-15 18:47:53 UTC) #3

pquitslund

4 years, 6 months ago (2016-06-15 19:14:25 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
35bbc6d305e4db41fbd8afcc564be1e7023a3b94 (presubmit successful).