Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 20606002: Make element offset test machine independent. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna
Modified:
7 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make element offset test machine independent. BUG= R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=25526

Patch Set 1 #

Patch Set 2 : Make offset test cross-machine #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -128 lines) Patch
A tests/html/element_offset_test.dart View 1 1 chunk +139 lines, -0 lines 1 comment Download
M tests/html/element_test.dart View 1 chunk +0 lines, -128 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Emily Fortuna
7 years, 4 months ago (2013-07-26 00:31:06 UTC) #1
Emily Fortuna
https://codereview.chromium.org/20606002/diff/3001/tests/html/element_offset_test.dart File tests/html/element_offset_test.dart (right): https://codereview.chromium.org/20606002/diff/3001/tests/html/element_offset_test.dart#newcode45 tests/html/element_offset_test.dart:45: document.body.style.whiteSpace = 'nowrap'; this is the one line that ...
7 years, 4 months ago (2013-07-26 00:56:09 UTC) #2
Jennifer Messerly
lgtm!
7 years, 4 months ago (2013-07-26 01:40:31 UTC) #3
Emily Fortuna
7 years, 4 months ago (2013-07-26 17:47:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r25526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698