Chromium Code Reviews
DescriptionFix for queue closed crash
It is possible for JavaScriptBackend.onQueueEmpty to be called twice, first time with isTreeShakingDisabled false (hence calling Enqueuer.enqueueReflectiveStaticFields), the second time with isTreeShakingDisabled true (hence calling Enqueuer.enqueueEverything). The crash is caused by using the same flag to avoid repeating work for enqueueReflectiveStaticFields and enqueueEverything.
The fix is to split the flag so we can enqueue statics and later enqueue everything.
R=floitsch@google.com, johnniwinther@google.com
Committed: https://code.google.com/p/dart/source/detail?r=34374
Patch Set 1 #Patch Set 2 : #
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||