Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2055973002: Revert "Make PbMapMixin implement Map<String, dynamic>" (Closed)

Created:
4 years, 6 months ago by skybrian
Modified:
4 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dart-protobuf.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Make PbMapMixin implement Map<String, dynamic>" We don't have a way to put type parameters on a mixin, so we can't do this yet. This reverts commit 97e5bb783f5babfd8161ec566684b71b524b1826. BUG= R=kevmoo@google.com Committed: https://github.com/dart-lang/protobuf/commit/7bc0bbb9e8a0440fbcddfb36c2e3d9a826b59bc8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 1 comment Download
M lib/src/protobuf/mixins/map_mixin.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/map_mixin_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
skybrian
4 years, 6 months ago (2016-06-09 20:57:32 UTC) #2
kevmoo
lgtm https://codereview.chromium.org/2055973002/diff/1/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2055973002/diff/1/CHANGELOG.md#newcode3 CHANGELOG.md:3: * Revert previous change. Add a bit more ...
4 years, 6 months ago (2016-06-09 21:11:58 UTC) #3
skybrian
On 2016/06/09 21:11:58, kevmoo wrote: > lgtm > > https://codereview.chromium.org/2055973002/diff/1/CHANGELOG.md > File CHANGELOG.md (right): > ...
4 years, 6 months ago (2016-06-09 21:16:55 UTC) #4
skybrian
4 years, 6 months ago (2016-06-09 21:17:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7bc0bbb9e8a0440fbcddfb36c2e3d9a826b59bc8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698