Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 205533005: Create a package that implements a JSON-RPC 2.0 server. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Create a package that implements a JSON-RPC 2.0 server. R=rnystrom@google.com BUG=17492 Committed: https://code.google.com/p/dart/source/detail?r=34223

Patch Set 1 #

Total comments: 55

Patch Set 2 : code review #

Total comments: 10

Patch Set 3 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1494 lines, -1 line) Patch
A + pkg/json_rpc_2/LICENSE View 0 chunks +-1 lines, --1 lines 0 comments Download
A pkg/json_rpc_2/README.md View 1 chunk +98 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/lib/error_code.dart View 1 1 chunk +36 lines, -0 lines 0 comments Download
A + pkg/json_rpc_2/lib/json_rpc_2.dart View 1 chunk +4 lines, -2 lines 0 comments Download
A pkg/json_rpc_2/lib/src/exception.dart View 1 chunk +65 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/lib/src/parameters.dart View 1 2 1 chunk +283 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/lib/src/server.dart View 1 2 1 chunk +220 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/lib/src/utils.dart View 1 chunk +45 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/pubspec.yaml View 1 chunk +13 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/test/server/batch_test.dart View 1 1 chunk +105 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/test/server/invalid_request_test.dart View 1 1 chunk +86 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/test/server/parameters_test.dart View 1 2 1 chunk +305 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/test/server/server_test.dart View 1 1 chunk +203 lines, -0 lines 0 comments Download
A pkg/json_rpc_2/test/server/utils.dart View 1 chunk +32 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 9 months ago (2014-03-20 00:17:24 UTC) #1
Bob Nystrom
I really really like this. I want to run an API idea past you. I ...
6 years, 9 months ago (2014-03-20 18:25:58 UTC) #2
nweiz
https://codereview.chromium.org/205533005/diff/1/pkg/json_rpc_2/README.md File pkg/json_rpc_2/README.md (right): https://codereview.chromium.org/205533005/diff/1/pkg/json_rpc_2/README.md#newcode64 pkg/json_rpc_2/README.md:64: `Server.parseRequest`: On 2014/03/20 18:25:58, Bob Nystrom wrote: > How ...
6 years, 9 months ago (2014-03-20 22:55:40 UTC) #3
Bob Nystrom
A few suggestions and nits, but LGTM. This looks awesome. https://codereview.chromium.org/205533005/diff/1/pkg/json_rpc_2/lib/src/parameters.dart File pkg/json_rpc_2/lib/src/parameters.dart (right): https://codereview.chromium.org/205533005/diff/1/pkg/json_rpc_2/lib/src/parameters.dart#newcode109 ...
6 years, 9 months ago (2014-03-21 00:36:01 UTC) #4
nweiz
https://codereview.chromium.org/205533005/diff/1/pkg/json_rpc_2/lib/src/server.dart File pkg/json_rpc_2/lib/src/server.dart (right): https://codereview.chromium.org/205533005/diff/1/pkg/json_rpc_2/lib/src/server.dart#newcode132 pkg/json_rpc_2/lib/src/server.dart:132: parameters = new Parameters(name, request['params']); On 2014/03/21 00:36:02, Bob ...
6 years, 9 months ago (2014-03-21 01:24:16 UTC) #5
nweiz
6 years, 9 months ago (2014-03-21 01:24:38 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r34223 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698