Auto delete persistent weak handles during finalization after invoking the callback associated with…

Auto delete persistent weak handles during finalization after invoking the callback associated with the weak handle.

R=iposva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34208

[Ivan Posva, 2014-03-19 23:08:14]

LGTM with comment.

-Ivan

https://codereview.chromium.org/205153002/diff/20001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/205153002/diff/20001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:378: if (callback != NULL) {
How can the callback be NULL, I thought it was a requirement that the callback
not be NULL.

[siva, 2014-03-20 20:05:32]

https://codereview.chromium.org/205153002/diff/20001/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/205153002/diff/20001/runtime/vm/dart_api_impl...
runtime/vm/dart_api_impl.cc:378: if (callback != NULL) {
good point changed that to an assert
ASSERT(callback != NULL);

and added checks in Dart_NewWeakPersistentHandle and
Dart_NewPrologueWeakPersistentHandle

On 2014/03/19 23:08:14, Ivan Posva wrote:
> How can the callback be NULL, I thought it was a requirement that the callback
> not be NULL.

[siva, 2014-03-20 21:45:47]

Committed patchset #5 manually as r34208 (presubmit successful).