Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 205033008: Regenerate dart:html for dart2js using Chrome 34 IDL (Closed)

Created:
6 years, 9 months ago by vsm
Modified:
6 years, 9 months ago
Reviewers:
Emily Fortuna, blois
CC:
reviews_dartlang.org, Jacob
Visibility:
Public.

Description

Regenerate dart:html for dart2js using Chrome 34 IDL (This is just a go.sh run.) R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=34368

Patch Set 1 #

Total comments: 6

Patch Set 2 : Regen #

Patch Set 3 : Suppress webkitMatchesSelector #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1558 lines, -2135 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 89 chunks +683 lines, -764 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 98 chunks +738 lines, -842 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 68 chunks +65 lines, -282 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 65 chunks +69 lines, -245 lines 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vsm
6 years, 9 months ago (2014-03-20 16:01:09 UTC) #1
blois
Looks good, primary fix is probably to hide matchesSelector as we should only expose it ...
6 years, 9 months ago (2014-03-20 16:51:00 UTC) #2
vsm
https://chromiumcodereview.appspot.com/205033008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (left): https://chromiumcodereview.appspot.com/205033008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#oldcode15419 sdk/lib/html/dart2js/html_dart2js.dart:15419: - bool seamless; On 2014/03/20 16:51:00, blois wrote: > ...
6 years, 9 months ago (2014-03-20 20:42:00 UTC) #3
vsm
[adding jacobr so our cl's don't cross]
6 years, 9 months ago (2014-03-20 20:42:46 UTC) #4
Emily Fortuna
https://chromiumcodereview.appspot.com/205033008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://chromiumcodereview.appspot.com/205033008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode11162 sdk/lib/html/dart2js/html_dart2js.dart:11162: + bool matchesSelector(String selectors) native; On 2014/03/20 20:42:01, vsm ...
6 years, 9 months ago (2014-03-21 16:26:50 UTC) #5
vsm
ptal https://chromiumcodereview.appspot.com/205033008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://chromiumcodereview.appspot.com/205033008/diff/1/sdk/lib/html/dart2js/html_dart2js.dart#newcode11162 sdk/lib/html/dart2js/html_dart2js.dart:11162: + bool matchesSelector(String selectors) native; On 2014/03/21 16:26:50, ...
6 years, 9 months ago (2014-03-25 14:51:26 UTC) #6
blois
lgtm
6 years, 9 months ago (2014-03-25 16:28:02 UTC) #7
vsm
6 years, 9 months ago (2014-03-25 16:29:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r34368 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698