Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issue 204983008: Rework how ServiceObjects are created and cached in Observatory. (Closed)

Created:
6 years, 9 months ago by turnidge
Modified:
6 years, 9 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch
Visibility:
Public.

Description

Rework how ServiceObjects are created and cached in Observatory. We now use a single cache, rather than per-type caches which simplifies the get() logic and makes it easier to add more model-types in the future. Rework how isolates are created/stored/retrieved. IsolateList is gone. Add canCache and immutable to ServiceObjects and use them to inform when an object should be cached or reloaded. Remove cache.dart, service.dart. Add a notion of a ServiceObjectOwner. Cleanups. Etc. Etc. R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34333

Patch Set 1 #

Patch Set 2 : before review #

Patch Set 3 : edits #

Total comments: 6

Patch Set 4 : gen js / fix 1 bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9351 lines, -9268 lines) Patch
M runtime/bin/vmservice/client/deployed/web/index.html View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js View 1 2 3 553 chunks +4480 lines, -4346 lines 0 comments Download
runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js.map View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js View 1 2 3 553 chunks +4480 lines, -4346 lines 0 comments Download
A runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js.map View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/class_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/eval_box.html View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M runtime/bin/vmservice/client/deployed/web/packages/observatory/src/elements/vm_view.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/service.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/class_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/eval_box.html View 1 1 chunk +1 line, -3 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/function_ref.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/isolate_profile.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/elements/vm_view.html View 1 1 chunk +1 line, -1 line 0 comments Download
D runtime/bin/vmservice/client/lib/src/service/cache.dart View 1 1 chunk +0 lines, -169 lines 0 comments Download
M runtime/bin/vmservice/client/lib/src/service/object.dart View 1 2 3 19 chunks +344 lines, -302 lines 0 comments Download
D runtime/bin/vmservice/client/lib/src/service/service.dart View 1 1 chunk +0 lines, -77 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
turnidge
6 years, 9 months ago (2014-03-24 19:57:36 UTC) #1
Cutch
lgtm with comments. https://codereview.chromium.org/204983008/diff/40001/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/204983008/diff/40001/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode9 runtime/bin/vmservice/client/lib/src/service/object.dart:9: bool _isServiceMap(ObservableMap m) { Maybe move ...
6 years, 9 months ago (2014-03-24 20:28:28 UTC) #2
turnidge
https://codereview.chromium.org/204983008/diff/40001/runtime/bin/vmservice/client/lib/src/service/object.dart File runtime/bin/vmservice/client/lib/src/service/object.dart (right): https://codereview.chromium.org/204983008/diff/40001/runtime/bin/vmservice/client/lib/src/service/object.dart#newcode9 runtime/bin/vmservice/client/lib/src/service/object.dart:9: bool _isServiceMap(ObservableMap m) { On 2014/03/24 20:28:29, Cutch wrote: ...
6 years, 9 months ago (2014-03-24 21:38:36 UTC) #3
turnidge
6 years, 9 months ago (2014-03-24 21:42:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r34333 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698