Issue 2048473002: Fix transformer tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2048473002: Fix transformer tests. (Closed)

Created:
4 years, 6 months ago by nweiz

Modified:
4 years, 6 months ago

Reviewers:
Chris Bracken

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/stream_channel.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix transformer tests. These tests should never have passed, since they were closing a sink before its controller emitted events. R=cbracken@google.com Committed: https://github.com/dart-lang/stream_channel/commit/ae466077de4cfd4b6edddf60ee64f9a6203ff73c

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	test/stream_channel_test.dart	View		3 chunks	+7 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

nweiz

4 years, 6 months ago (2016-06-06 23:54:40 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ae466077de4cfd4b6edddf60ee64f9a6203ff73c (presubmit successful).