Add admin server that supports web socket API.

Add admin server that supports web socket API.

BUG=https://code.google.com/p/dart/issues/detail?id=16957
R=keertip@google.com, nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34220

[Bob Nystrom, 2014-03-19 21:18:47]

The existing ports will serve the web socket API, but this creates a dedicated
"admin" port that also supports it.

Keerti, to use this, you'll want to pass --log-admin-url to pub serve. That
tells it to print out the URL for the admin server that you want to connect to,
like so:

$ pub serve --log-admin-url
Loading source assets...
Running admin server on http://localhost:8079
Serving my_app web on http://localhost:8080
Build completed successfully

If you use an explicit port (like the default of 8080) then it will reliably be
that port -1 and you don't need to print it. If you use an ephemeral port,
though, this will let you know what port it ended up picking.

[nweiz, 2014-03-20 00:40:21]

lgtm

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/admin_server.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/admin_server.dart:27: /// the root
directory.
This sentence isn't accurate anymore.

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/admin_server.dart:73:
_webSockets.remove(api);
Nit: =>

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/barback_server.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/barback_server.dart:97: @override
We don't usually use these...

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/base_server.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/base_server.dart:91: void addResult(T
result) {
Rather than expose these manually, it may be cleaner to just make
[resultsController] public.

This whole file makes me wish we had protected in Dart, though.

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/build_environment.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:146: // The admin
server is bound to one before the base port, unless its
"its" -> "it's"

[keertip, 2014-03-20 16:33:22]

lgtm! Will switch over once Nathan's changes to the api are in.

[Bob Nystrom, 2014-03-21 00:57:17]

Committed patchset #2 manually as r34220 (presubmit successful).

[Bob Nystrom, 2014-03-21 01:01:49]

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/admin_server.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/admin_server.dart:27: /// the root
directory.
On 2014/03/20 00:40:21, nweiz wrote:
> This sentence isn't accurate anymore.

Done.

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/admin_server.dart:73:
_webSockets.remove(api);
On 2014/03/20 00:40:21, nweiz wrote:
> Nit: =>

Done.

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/barback_server.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/barback_server.dart:97: @override
On 2014/03/20 00:40:21, nweiz wrote:
> We don't usually use these...

Heh. I was poking at an analyzer issue and forgot to remove that. :)

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/base_server.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/base_server.dart:91: void addResult(T
result) {
On 2014/03/20 00:40:21, nweiz wrote:
> Rather than expose these manually, it may be cleaner to just make
> [resultsController] public.
> 
> This whole file makes me wish we had protected in Dart, though.

Protected would be nice. Making the controller itself public felt a little too
gratuitous, so I figured this was a nice trade-off.

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/build_environment.dart (right):

https://codereview.chromium.org/204673006/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:146: // The admin
server is bound to one before the base port, unless its
On 2014/03/20 00:40:21, nweiz wrote:
> "its" -> "it's"

Done.