Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 20467004: Inline two argument shuffle operations on IA32 and X64. (Closed)

Created:
7 years, 5 months ago by Cutch
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org, zra
Visibility:
Public.

Description

Inline two argument shuffle operations on IA32 and X64. R=vegorov@google.com Committed: https://code.google.com/p/dart/source/detail?r=25580

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+247 lines, -25 lines) Patch
M runtime/vm/disassembler_ia32.cc View 1 2 3 5 chunks +31 lines, -20 lines 0 comments Download
M runtime/vm/disassembler_x64.cc View 2 chunks +15 lines, -5 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 2 chunks +25 lines, -0 lines 0 comments Download
M runtime/vm/flow_graph_type_propagator.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 2 4 chunks +60 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
tests/lib/lib.status View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Cutch
Zack- see new unimplemented instruction for ARM.
7 years, 5 months ago (2013-07-25 21:21:19 UTC) #1
Vyacheslav Egorov (Google)
ia32/x64/generic part LGTM
7 years, 5 months ago (2013-07-26 07:52:44 UTC) #2
Cutch
7 years, 4 months ago (2013-07-29 18:57:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r25580 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698