Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2044263002: Silence dart2js's success output. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
jakemac, kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Silence dart2js's success output. This output was added in a recent dart2js version, and it's redundant with test's own output. It's also breaking tests. R=jakemac@google.com, kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/a3fe6ab2d4357498294777afef6cd1fa83af12ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M lib/src/runner/browser/compiler_pool.dart View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 6 months ago (2016-06-07 20:38:52 UTC) #1
jakemac
lgtm
4 years, 6 months ago (2016-06-07 21:48:30 UTC) #3
nweiz
4 years, 6 months ago (2016-06-07 21:49:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a3fe6ab2d4357498294777afef6cd1fa83af12ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698