Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 204353002: Status file updates for running pkg tests on ie10 (Closed)

Created:
6 years, 9 months ago by ricow1
Modified:
6 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Status file updates for running pkg tests on ie10 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=34110

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M pkg/pkg.status View 1 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
6 years, 9 months ago (2014-03-19 09:20:44 UTC) #1
kustermann
LGTM https://codereview.chromium.org/204353002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/204353002/diff/1/pkg/pkg.status#newcode126 pkg/pkg.status:126: typed_data/test/typed_buffers_test: Fail # Issue 17607 (I put this ...
6 years, 9 months ago (2014-03-19 09:23:14 UTC) #2
ricow1
https://codereview.chromium.org/204353002/diff/1/pkg/pkg.status File pkg/pkg.status (right): https://codereview.chromium.org/204353002/diff/1/pkg/pkg.status#newcode126 pkg/pkg.status:126: typed_data/test/typed_buffers_test: Fail # Issue 17607 (I put this here ...
6 years, 9 months ago (2014-03-19 09:25:05 UTC) #3
ricow1
Committed patchset #2 manually as r34110 (presubmit successful).
6 years, 9 months ago (2014-03-19 09:25:23 UTC) #4
Jennifer Messerly
6 years, 9 months ago (2014-03-19 19:13:51 UTC) #5
Message was sent while issue was closed.
lovely! lgtm

Powered by Google App Engine
This is Rietveld 408576698