Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Issue 204343003: Close(destroy) Socket on user-generated write error. (Closed)

Created:
6 years, 9 months ago by Anders Johnsen
Modified:
6 years, 9 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Close(destroy) Socket on user-generated write error. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34109

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M runtime/bin/socket_patch.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M tests/standalone/io/socket_invalid_arguments_test.dart View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Anders Johnsen
6 years, 9 months ago (2014-03-19 08:52:29 UTC) #1
Søren Gjesse
lgtm
6 years, 9 months ago (2014-03-19 09:22:47 UTC) #2
Anders Johnsen
6 years, 9 months ago (2014-03-19 09:23:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r34109 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698