Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2041983003: Add StreamChannel.withCloseGuarantee. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/stream_channel.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add StreamChannel.withCloseGuarantee. This also properly enforces the close guarantee for transformers provided by this package. R=rnystrom@google.com Committed: https://github.com/dart-lang/stream_channel/commit/f155869c249525a969f5456d88c8c83d61f0e34d

Patch Set 1 #

Total comments: 4

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -5 lines) Patch
M CHANGELOG.md View 1 chunk +11 lines, -0 lines 0 comments Download
A lib/src/close_guarantee_channel.dart View 1 1 chunk +86 lines, -0 lines 0 comments Download
M lib/src/json_document_transformer.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/src/stream_channel_transformer.dart View 2 chunks +9 lines, -2 lines 0 comments Download
M lib/stream_channel.dart View 3 chunks +16 lines, -2 lines 0 comments Download
A test/with_close_guarantee_test.dart View 1 chunk +66 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
nweiz
4 years, 6 months ago (2016-06-06 22:08:11 UTC) #1
Bob Nystrom
lgtm https://codereview.chromium.org/2041983003/diff/1/lib/src/close_guarantee_channel.dart File lib/src/close_guarantee_channel.dart (right): https://codereview.chromium.org/2041983003/diff/1/lib/src/close_guarantee_channel.dart#newcode12 lib/src/close_guarantee_channel.dart:12: /// guarantee. To someone reading this doc cold, ...
4 years, 6 months ago (2016-06-06 22:54:53 UTC) #2
nweiz
Code review changes
4 years, 6 months ago (2016-06-06 23:25:20 UTC) #3
nweiz
https://codereview.chromium.org/2041983003/diff/1/lib/src/close_guarantee_channel.dart File lib/src/close_guarantee_channel.dart (right): https://codereview.chromium.org/2041983003/diff/1/lib/src/close_guarantee_channel.dart#newcode12 lib/src/close_guarantee_channel.dart:12: /// guarantee. On 2016/06/06 22:54:53, Bob Nystrom wrote: > ...
4 years, 6 months ago (2016-06-06 23:25:30 UTC) #4
nweiz
4 years, 6 months ago (2016-06-06 23:25:44 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f155869c249525a969f5456d88c8c83d61f0e34d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698