Issue 20419002: Disable offset test until it is reproducible across machines.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20419002: Disable offset test until it is reproducible across machines. (Closed)

Created:
7 years, 4 months ago by Emily Fortuna

Modified:
7 years, 4 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Disable offset test until it is reproducible across machines. BUG= Committed: https://code.google.com/p/dart/source/detail?r=25490

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	tests/html/element_test.dart	View	1	4 chunks	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

TBR. There's a Firefox failure that's I can't seem to repro on my machine. Not ...

7 years, 4 months ago (2013-07-25 18:48:46 UTC) #1

Emily Fortuna

Committed patchset #2 manually as r25490 (presubmit successful).

7 years, 4 months ago (2013-07-25 18:49:19 UTC) #2

Jennifer Messerly

7 years, 4 months ago (2013-07-25 19:37:49 UTC) #3

Message was sent while issue was closed.

lgtm :(

suggestion -- split these tests out of element_test? that way you could mark
them failing in the html.status file without losing test coverage for everything
else in element_test

Expand Messages | Collapse Messages