Create package for HTML imports

Create package for HTML imports

R=jmesserly@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25505

[Siggi Cherem (dart-lang), 2013-07-25 18:48:49]

couple questions:
 - I was debating between naming this 'html_import' or 'html_imports'
 - I'm not sure about putting this here or not. One alternative is to create a
fork in github where we can add a pubspec?

[Jennifer Messerly, 2013-07-25 19:34:27]

> couple questions:
> - I was debating between naming this 'html_import' or 'html_imports'

yeah, +1 on singular, I think that's in our pkg naming guidelines

> - I'm not sure about putting this here or not. One alternative is to create a
fork in github where we can add a pubspec?

we still need to vendor it in to googlecode for testing, right?

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md
File pkg/html_import/README.md (right):

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:3: HTML Imports are a way to include and reuse HTML
documents in other HTML documents. As `<script>` tags let authors include
external Javascript in their pages, imports let authors load full HTML
resources.  In particular, imports let authors include [Custom
Element](https://github.com/Polymer/CustomElements) definitions from external
URLs.
long line :)

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:10: <script
src="packages/html_import/html-imports.js"></script>
this should be _?

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/pubspec.yaml
File pkg/html_import/pubspec.yaml (right):

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/pubspec.yaml#...
pkg/html_import/pubspec.yaml:5: This package wraps polymer's HTMLImports.
I think this line will confuse new readers. this is the first sentence they will
read about HTML imports :)

In the descriptions for:

http://pub.dartlang.org/packages/polymer
http://pub.dartlang.org/packages/shadow_dom
http://pub.dartlang.org/packages/mdv

... I tried to just say what the pkg is. The larger context is good for readme
tho :)

[Jennifer Messerly, 2013-07-25 19:35:11]

oops, one more comment

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md
File pkg/html_import/README.md (right):

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:1: # HTML Imports polyfill
link the spec?
https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/imports/index.html

[Siggi Cherem (dart-lang), 2013-07-25 20:48:40]

ptal

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md
File pkg/html_import/README.md (right):

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:1: # HTML Imports polyfill
On 2013/07/25 19:35:11, John Messerly wrote:
> link the spec?
> https://dvcs.w3.org/hg/webcomponents/raw-file/tip/spec/imports/index.html

Done.

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:3: HTML Imports are a way to include and reuse HTML
documents in other HTML documents. As `<script>` tags let authors include
external Javascript in their pages, imports let authors load full HTML
resources.  In particular, imports let authors include [Custom
Element](https://github.com/Polymer/CustomElements) definitions from external
URLs.
On 2013/07/25 19:34:27, John Messerly wrote:
> long line :)

Done. I copied it over from their file =)

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:10: <script
src="packages/html_import/html-imports.js"></script>
On 2013/07/25 19:34:27, John Messerly wrote:
> this should be _?

Their file is actually '-', should I rename it?

If so, maybe I should match the name of the package? html_import.js (or
html_import.debug.js) and html_import.min.js

Thoughts?

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/pubspec.yaml
File pkg/html_import/pubspec.yaml (right):

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/pubspec.yaml#...
pkg/html_import/pubspec.yaml:5: This package wraps polymer's HTMLImports.
On 2013/07/25 19:34:27, John Messerly wrote:
> I think this line will confuse new readers. this is the first sentence they
will
> read about HTML imports :)
> 
> In the descriptions for:
> 
> http://pub.dartlang.org/packages/polymer
> http://pub.dartlang.org/packages/shadow_dom
> http://pub.dartlang.org/packages/mdv
> 
> ... I tried to just say what the pkg is. The larger context is good for readme
> tho :)

Ok. removed.

[Jennifer Messerly, 2013-07-25 20:51:08]

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md
File pkg/html_import/README.md (right):

https://codereview.chromium.org/20414002/diff/1/pkg/html_import/README.md#new...
pkg/html_import/README.md:10: <script
src="packages/html_import/html-imports.js"></script>
On 2013/07/25 20:48:40, Siggi Cherem (dart-lang) wrote:
> On 2013/07/25 19:34:27, John Messerly wrote:
> > this should be _?
> 
> Their file is actually '-', should I rename it?
> 
> If so, maybe I should match the name of the package? html_import.js (or
> html_import.debug.js) and html_import.min.js
> 
> Thoughts?

yeah, I would rename it to match pkg name. After chatting w/ some folks I
changed Shadow DOM to match Dart pkg naming guidelines: shadow_dom

IMHO, making changes to conform to expected pkg/asset naming conventions in Dart
is totally okay...

[Siggi Cherem (dart-lang), 2013-07-25 21:35:26]

thanks, all set

[Jennifer Messerly, 2013-07-25 21:40:25]

lgtm

[Siggi Cherem (dart-lang), 2013-07-25 21:57:13]

Committed patchset #4 manually as r25505 (presubmit successful).