Issue 204103009: Add class and address information to heap map; display on hover.

Issue 204103009: Add class and address information to heap map; display on hover. (Closed)

Created:
6 years, 9 months ago by koda

Modified:
6 years, 9 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add class and address information to heap map; display on hover. Display a string like "String @ 0xe97c3328" while hovering over the map. Also add page separators (black). R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=34195

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2

Patch Set 5 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2654 lines, -2010 lines)			Patch
M	runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart.js	View		414 chunks	+1251 lines, -976 lines	0 comments	Download
M	runtime/bin/vmservice/client/deployed/web/index_devtools.html_bootstrap.dart.js	View		414 chunks	+1251 lines, -976 lines	0 comments	Download
M	runtime/bin/vmservice/client/lib/src/elements/heap_map.dart	View	1 2 3 4	3 chunks	+126 lines, -41 lines	0 comments	Download
M	runtime/vm/class_table.h	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	runtime/vm/class_table.cc	View	1 2 3 4	1 chunk	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/heap.h	View	1 2 3 4	1 chunk	+3 lines, -3 lines	0 comments	Download
M	runtime/vm/pages.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/pages.cc	View	1 2 3 4	2 chunks	+12 lines, -4 lines	0 comments	Download
M	runtime/vm/service.cc	View	1 2 3 4	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/service_test.cc	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

koda

Demo running here: http://koda-linux.mtv.corp.google.com:3030/client/web/index.html#/isolates/7114/heapmap

6 years, 9 months ago (2014-03-19 18:50:33 UTC) #2

Cutch

lgtm w/ comments https://codereview.chromium.org/204103009/diff/60001/runtime/vm/class_table.cc File runtime/vm/class_table.cc (right): https://codereview.chromium.org/204103009/diff/60001/runtime/vm/class_table.cc#newcode172 runtime/vm/class_table.cc:172: object->AddProperty("type", "ClassList"); Please add an id: ...

6 years, 9 months ago (2014-03-20 17:25:57 UTC) #3

koda

Also tested JS version. https://codereview.chromium.org/204103009/diff/60001/runtime/vm/class_table.cc File runtime/vm/class_table.cc (right): https://codereview.chromium.org/204103009/diff/60001/runtime/vm/class_table.cc#newcode172 runtime/vm/class_table.cc:172: object->AddProperty("type", "ClassList"); On 2014/03/20 17:25:57, ...

6 years, 9 months ago (2014-03-20 18:55:47 UTC) #4

koda

6 years, 9 months ago (2014-03-20 18:56:50 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r34195 (presubmit successful).

Expand Messages | Collapse Messages