Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 2040883003: Add support for passing in precompiled JS. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Chris Bracken
CC:
reviews_dartlang.org, heathkit
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add support for passing in precompiled JS. This is useful internally for Google, and is not considered a public feature with stability guarantees. Currently this doesn't support --pub-serve mode. If that becomes necessary, it can be added later. R=cbracken@google.com Committed: https://github.com/dart-lang/test/commit/686195a40e8b85050be834dfc9efb56866654ca8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -1 line) Patch
M lib/src/runner/browser/platform.dart View 3 chunks +16 lines, -1 line 0 comments Download
M lib/src/runner/configuration.dart View 7 chunks +12 lines, -0 lines 0 comments Download
M lib/src/runner/configuration/args.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M test/runner/configuration/configuration_test.dart View 8 chunks +8 lines, -0 lines 0 comments Download
A test/runner/precompiled_paths_test.dart View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
nweiz
4 years, 6 months ago (2016-06-06 22:50:47 UTC) #2
Chris Bracken
lgtm
4 years, 6 months ago (2016-06-07 18:46:56 UTC) #3
nweiz
4 years, 6 months ago (2016-06-07 18:50:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
686195a40e8b85050be834dfc9efb56866654ca8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698