Issue 204033003: Updating code_transformers to not fail on syntax errors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204033003: Updating code_transformers to not fail on syntax errors (Closed)

Created:
6 years, 9 months ago by blois

Modified:
6 years, 9 months ago

Reviewers:
Siggi Cherem (dart-lang), scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Updating code_transformers to not fail on syntax errors Recent changes started using the Analyzer's parseCompilationUnit method which throws exceptions on syntax errors, but this is undesirable in many cases. Adding an option to disable this behavior and using that in code_transformers. BUG= R=scheglov@google.com, sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=34070

Patch Set 1 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+24 lines, -6 lines)			Patch
M	pkg/analyzer/lib/analyzer.dart	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	pkg/code_transformers/lib/src/entry_point.dart	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/code_transformers/lib/src/resolver_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/code_transformers/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/code_transformers/test/entry_point_test.dart	View	1 chunk	+16 lines, -0 lines	0 comments	Download
M	pkg/polymer/pubspec.yaml	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

blois

6 years, 9 months ago (2014-03-18 22:09:24 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r34070 (presubmit successful).

Expand Messages | Collapse Messages