Issue 204033002: Fixes for Chrome 34 merge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204033002: Fixes for Chrome 34 merge (Closed)

Created:
6 years, 9 months ago by Jacob

Modified:
6 years, 9 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+524 lines, -65 lines)			Patch
M	tests/html/html.status	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	39 chunks	+345 lines, -3 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	2 chunks	+10 lines, -1 line	0 comments	Download
M	tools/dom/scripts/generator.py	View	11 chunks	+51 lines, -48 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	4 chunks	+3 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/idlnode.py	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/idlparser.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/scripts/systemnative.py	View	9 chunks	+90 lines, -6 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/dom/templates/html/dartium/cpp_header.template	View	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Jacob

These have already been reviewed. This CL just merges all the fixes and strips out ...

6 years, 9 months ago (2014-03-18 21:51:59 UTC) #1

Jacob

6 years, 9 months ago (2014-03-18 22:08:52 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34069 (presubmit successful).