Support wedging isolates before startup or before exit.

Support wedging isolates before startup or before exit.

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34079

[turnidge, 2014-03-18 21:45:37]

lgtm w/ c.

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:440: result->message_handler()->set_wedge_on_exit(true);
How about:

--pause_Isolates_on_start
--pause_isolates_on_exit

and corresponding changes in the code?

(Better to change the flag name now, imo).

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:266: }
Add comment here.

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1432: static bool HandleUnpin(Isolate* isolate,
JSONStream* js) {
Can we call this resume instead of unpin?  That way I can reuse it eventually
for the debugger.

[Cutch, 2014-03-18 23:32:32]

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/isolate.cc
File runtime/vm/isolate.cc (right):

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/isolate.cc#ne...
runtime/vm/isolate.cc:440: result->message_handler()->set_wedge_on_exit(true);
On 2014/03/18 21:45:37, turnidge wrote:
> How about:
> 
> --pause_Isolates_on_start
> --pause_isolates_on_exit
> 
> and corresponding changes in the code?
> 
> (Better to change the flag name now, imo).

Done.

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/service.cc
File runtime/vm/service.cc (right):

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:266: }
On 2014/03/18 21:45:37, turnidge wrote:
> Add comment here.

Done.

https://codereview.chromium.org/204003002/diff/20001/runtime/vm/service.cc#ne...
runtime/vm/service.cc:1432: static bool HandleUnpin(Isolate* isolate,
JSONStream* js) {
On 2014/03/18 21:45:37, turnidge wrote:
> Can we call this resume instead of unpin?  That way I can reuse it eventually
> for the debugger.

Done.

[Cutch, 2014-03-18 23:32:41]

Committed patchset #4 manually as r34079 (presubmit successful).