Issue 203913004: pkg/docgen: marking status for known static warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203913004: pkg/docgen: marking status for known static warnings (Closed)

Created:
6 years, 9 months ago by kevmoo

Modified:
6 years, 9 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

pkg/docgen: marking status for known static warnings Also include failure for Issue 17597 TBR Committed: https://code.google.com/p/dart/source/detail?r=34080

Patch Set 1 #

Total comments: 1

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	pkg/pkg.status	View		2 chunks	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kevmoo

Committed patchset #1 manually as r34080 (presubmit successful).

6 years, 9 months ago (2014-03-18 23:42:41 UTC) #1

Alan Knight

6 years, 9 months ago (2014-03-18 23:55:48 UTC) #3

Message was sent while issue was closed.

lgtm

https://codereview.chromium.org/203913004/diff/1/pkg/pkg.status
File pkg/pkg.status (right):

https://codereview.chromium.org/203913004/diff/1/pkg/pkg.status#newcode31
pkg/pkg.status:31: docgen\test\only_lib_content_in_pkg_test: Fail # Issue 17597
This looks like the mirror system creation isn't given the package root.

Expand Messages | Collapse Messages