Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Issue 203913003: Share code between the transformer isolate and pub proper. (Closed)

Created:
6 years, 9 months ago by nweiz
Modified:
6 years, 9 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Share code between the transformer isolate and pub proper. R=rnystrom@google.com BUG=17506 Committed: https://code.google.com/p/dart/source/detail?r=34084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+495 lines, -625 lines) Patch
A sdk/lib/_internal/pub/asset/dart/serialize.dart View 1 chunk +100 lines, -0 lines 0 comments Download
A sdk/lib/_internal/pub/asset/dart/serialize/exception.dart View 1 chunk +102 lines, -0 lines 0 comments Download
A sdk/lib/_internal/pub/asset/dart/serialize/transform.dart View 1 chunk +126 lines, -0 lines 0 comments Download
A sdk/lib/_internal/pub/asset/dart/serialize/transformer.dart View 1 chunk +60 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/asset/dart/transformer_isolate.dart View 3 chunks +10 lines, -339 lines 0 comments Download
A sdk/lib/_internal/pub/asset/dart/utils.dart View 1 chunk +86 lines, -0 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/build_environment.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/pub/lib/src/barback/load_transformers.dart View 5 chunks +6 lines, -166 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/dart.dart View 2 chunks +1 line, -41 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/utils.dart View 4 chunks +3 lines, -78 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 9 months ago (2014-03-18 20:07:05 UTC) #1
Bob Nystrom
Assuming this is mostly just moving code around, LGTM. Stuff that looked the same I ...
6 years, 9 months ago (2014-03-18 22:14:30 UTC) #2
nweiz
6 years, 9 months ago (2014-03-18 23:57:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r34084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698