Issue 20385002: Added shim for scrollX and scrollY for IE 9.

Issue 20385002: Added shim for scrollX and scrollY for IE 9. (Closed)

Created:
7 years, 5 months ago by Emily Fortuna

Modified:
7 years, 5 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added shim for scrollX and scrollY for IE 9. BUG= R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=25529

Patch Set 6 : #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -12 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View		2 chunks	+5 lines, -8 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
A +	tests/html/window_test.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	tools/dom/scripts/systemhtml.py	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_Window.darttemplate	View	1 2 3 4 5	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

Fix for https://code.google.com/p/dart/issues/detail?id=10678

7 years, 5 months ago (2013-07-25 21:10:07 UTC) #1

blois

https://codereview.chromium.org/20385002/diff/5001/tools/dom/templates/html/impl/impl_Window.darttemplate File tools/dom/templates/html/impl/impl_Window.darttemplate (right): https://codereview.chromium.org/20385002/diff/5001/tools/dom/templates/html/impl/impl_Window.darttemplate#newcode285 tools/dom/templates/html/impl/impl_Window.darttemplate:285: int get scrollX() => Device.isIE ? document.documentElement.scrollLeft : Can ...

7 years, 5 months ago (2013-07-25 21:30:03 UTC) #2

blois

https://codereview.chromium.org/20385002/diff/14001/sdk/lib/html/dartium/html_dartium.dart File sdk/lib/html/dartium/html_dartium.dart (right): https://codereview.chromium.org/20385002/diff/14001/sdk/lib/html/dartium/html_dartium.dart#newcode25814 sdk/lib/html/dartium/html_dartium.dart:25814: + int get $dom_scrollY native "Window_scrollY_Getter"; Change should be ...

7 years, 5 months ago (2013-07-26 00:36:23 UTC) #4

blois

lgtm https://codereview.chromium.org/20385002/diff/19002/sdk/lib/html/dart2js/html_dart2js.dart File sdk/lib/html/dart2js/html_dart2js.dart (right): https://codereview.chromium.org/20385002/diff/19002/sdk/lib/html/dart2js/html_dart2js.dart#newcode24962 sdk/lib/html/dart2js/html_dart2js.dart:24962: + int get scrollX => JS('bool', '"scrollX" in ...

7 years, 5 months ago (2013-07-26 15:38:01 UTC) #6

Emily Fortuna

7 years, 5 months ago (2013-07-26 18:09:22 UTC) #7

Message was sent while issue was closed.

Committed patchset #6 manually as r25529 (presubmit successful).

Expand Messages | Collapse Messages