Add transformer support to Converters.

Add transformer support to Converters.

R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=25517

[Søren Gjesse, 2013-07-26 07:37:23]

LGTM!

Good test coverage!

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
File sdk/lib/convert/chunked_conversion.dart (right):

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
sdk/lib/convert/chunked_conversion.dart:57: : this._withEventTransformer(
Why do you need two constructors?

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
sdk/lib/convert/chunked_conversion.dart:95: /** At every [handleData] this field
is updated with the new event sink. */
I don't think this should be a dartdoc comment.

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
sdk/lib/convert/chunked_conversion.dart:98: /**
Ditto.

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/json_uni...
File tests/lib/convert/json_unicode_tests.dart (right):

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/json_uni...
tests/lib/convert/json_unicode_tests.dart:17: return UNICODE_TESTS.expand((test)
{
Please add a comment listing the different JSONs generated.

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
File tests/lib/convert/streamed_conversion_json_decode1_test.dart (right):

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
tests/lib/convert/streamed_conversion_json_decode1_test.dart:56:
createStream(List<String> chunks) {
Add return type Stream.

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
File tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart (right):

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart:34:
createStream(List<List<int>> chunks) {
Add return type Stream

[floitsch, 2013-07-26 10:35:31]

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
File sdk/lib/convert/chunked_conversion.dart (right):

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
sdk/lib/convert/chunked_conversion.dart:57: : this._withEventTransformer(
On 2013/07/26 07:37:23, Søren Gjesse wrote:
> Why do you need two constructors?

Because I need to initialize a final field and super with the same variable
("new _ConverterStreamEventTransformer").
I don't know of a better way to do this.

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
sdk/lib/convert/chunked_conversion.dart:95: /** At every [handleData] this field
is updated with the new event sink. */
On 2013/07/26 07:37:23, Søren Gjesse wrote:
> I don't think this should be a dartdoc comment.

It's inside a private class, but done. (I initially hesitated too)

https://codereview.chromium.org/20374003/diff/2001/sdk/lib/convert/chunked_co...
sdk/lib/convert/chunked_conversion.dart:98: /**
On 2013/07/26 07:37:23, Søren Gjesse wrote:
> Ditto.

Done.

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/json_uni...
File tests/lib/convert/json_unicode_tests.dart (right):

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/json_uni...
tests/lib/convert/json_unicode_tests.dart:17: return UNICODE_TESTS.expand((test)
{
On 2013/07/26 07:37:23, Søren Gjesse wrote:
> Please add a comment listing the different JSONs generated.

Done.

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
File tests/lib/convert/streamed_conversion_json_decode1_test.dart (right):

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
tests/lib/convert/streamed_conversion_json_decode1_test.dart:56:
createStream(List<String> chunks) {
On 2013/07/26 07:37:23, Søren Gjesse wrote:
> Add return type Stream.

Done.

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
File tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart (right):

https://codereview.chromium.org/20374003/diff/2001/tests/lib/convert/streamed...
tests/lib/convert/streamed_conversion_json_utf8_decode_test.dart:34:
createStream(List<List<int>> chunks) {
On 2013/07/26 07:37:23, Søren Gjesse wrote:
> Add return type Stream

Done.

[floitsch, 2013-07-26 10:35:56]

Committed patchset #3 manually as r25517 (presubmit successful).