Issue 20369004: [mdv] fix analyzer failure in select_element.dart

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20369004: [mdv] fix analyzer failure in select_element.dart (Closed)

Created:
7 years, 5 months ago by Jennifer Messerly

Modified:
7 years, 5 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

[mdv] fix analyzer failure in select_element.dart Committed: https://code.google.com/p/dart/source/detail?r=25489

Patch Set 1 #

Total comments: 1

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	pkg/mdv/lib/src/select_element.dart	View		1 chunk	+1 line, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jennifer Messerly

TBR, fixing bot https://codereview.chromium.org/20369004/diff/1/pkg/mdv/lib/src/select_element.dart File pkg/mdv/lib/src/select_element.dart (right): https://codereview.chromium.org/20369004/diff/1/pkg/mdv/lib/src/select_element.dart#newcode14 pkg/mdv/lib/src/select_element.dart:14: if (name.toLowerCase() == 'selectedindex') { apparently, ...

7 years, 5 months ago (2013-07-25 18:46:57 UTC) #1

Jennifer Messerly

Committed patchset #1 manually as r25489 (presubmit successful).

7 years, 5 months ago (2013-07-25 18:47:14 UTC) #2

Message was sent while issue was closed.

lgtm

wow

Expand Messages | Collapse Messages