Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Issue 20364002: Remove API documentation from path README. (Closed)

Created:
7 years, 4 months ago by Bob Nystrom
Modified:
7 years, 4 months ago
Reviewers:
nweiz
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove API documentation from path README. BUG=https://code.google.com/p/dart/issues/detail?id=8072 R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=25513

Patch Set 1 #

Total comments: 2

Patch Set 2 : Revise. #

Patch Set 3 : Add doc link to pubspec. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -357 lines) Patch
M pkg/path/README.md View 1 3 chunks +23 lines, -342 lines 0 comments Download
M pkg/path/lib/path.dart View 8 chunks +48 lines, -14 lines 0 comments Download
M pkg/path/pubspec.yaml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/path/test/posix_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download
M pkg/path/test/url_test.dart View 3 chunks +10 lines, -1 line 0 comments Download
M pkg/path/test/windows_test.dart View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bob Nystrom
We've got real API docs for path online now (http://api.dartlang.org/docs/bleeding_edge/path.html), so we don't need them ...
7 years, 4 months ago (2013-07-25 17:29:13 UTC) #1
nweiz
Shouldn't the README link to the API docs? Or the pubspec? https://codereview.chromium.org/20364002/diff/1/pkg/path/README.md File pkg/path/README.md (right): ...
7 years, 4 months ago (2013-07-25 23:14:13 UTC) #2
Bob Nystrom
The package page itself will link to the docs so I don't think we need ...
7 years, 4 months ago (2013-07-25 23:23:37 UTC) #3
nweiz
Args has a "documentation" link in its pubspec, though, which path currently does not.
7 years, 4 months ago (2013-07-25 23:45:16 UTC) #4
nweiz
lgtm, although you should wait on the other pathos change before submitting this one.
7 years, 4 months ago (2013-07-25 23:59:20 UTC) #5
Bob Nystrom
7 years, 4 months ago (2013-07-26 00:18:57 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 manually as r25513 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698