Issue 203603008: Introduce class Sink<T>.

Issue 203603008: Introduce class Sink<T>. (Closed)

Created:
6 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 9 months ago

Reviewers:
Anders Johnsen, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Introduce class Sink<T>. The sink only has "add" and "close" methods. It is the supertype of both EventSink and ChunkedConversionSink. Made startChunkedConversion take Sink as argument, but still return ChunkedConversionSink. The more specialized chunked conversion sinks are test for, just as they always were. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=34157

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address comments. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+83 lines, -66 lines)			Patch
M	pkg/analysis_server/lib/src/channel.dart	View		3 chunks	+8 lines, -8 lines	0 comments	Download
M	sdk/lib/async/stream.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/convert/ascii.dart	View		3 chunks	+3 lines, -6 lines	0 comments	Download
M	sdk/lib/convert/byte_conversion.dart	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/convert/chunked_conversion.dart	View		2 chunks	+6 lines, -3 lines	0 comments	Download
M	sdk/lib/convert/converter.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/convert/html_escape.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/convert/json.dart	View		4 chunks	+6 lines, -8 lines	0 comments	Download
M	sdk/lib/convert/latin1.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sdk/lib/convert/line_splitter.dart	View		1 chunk	+1 line, -3 lines	0 comments	Download
M	sdk/lib/convert/string_conversion.dart	View		3 chunks	+7 lines, -8 lines	0 comments	Download
M	sdk/lib/convert/utf.dart	View		2 chunks	+2 lines, -4 lines	0 comments	Download
M	sdk/lib/core/core.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/core/corelib_sources.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
A	sdk/lib/core/sink.dart	View	1	1 chunk	+31 lines, -0 lines	0 comments	Download
M	sdk/lib/io/data_transformer.dart	View		2 chunks	+5 lines, -9 lines	0 comments	Download
M	sdk/lib/io/string_transformer.dart	View		4 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

lgtm https://codereview.chromium.org/203603008/diff/1/sdk/lib/core/sink.dart File sdk/lib/core/sink.dart (right): https://codereview.chromium.org/203603008/diff/1/sdk/lib/core/sink.dart#newcode8 sdk/lib/core/sink.dart:8: * A generic destination for data. data or ...

6 years, 9 months ago (2014-03-19 13:12:01 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/203603008/diff/1/sdk/lib/core/sink.dart File sdk/lib/core/sink.dart (right): https://codereview.chromium.org/203603008/diff/1/sdk/lib/core/sink.dart#newcode8 sdk/lib/core/sink.dart:8: * A generic destination for data. Data. It's as ...

6 years, 9 months ago (2014-03-19 15:25:26 UTC) #3

Lasse Reichstein Nielsen

6 years, 9 months ago (2014-03-20 10:13:16 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r34157 (presubmit successful).

Expand Messages | Collapse Messages