Make VersionRange implement Comparable.

Make VersionRange implement Comparable.

This changes the ordering of ranges in a VersionUnion. It used to order
solely by the upper bound; it now orders by lower bound, then upper
bound. In addition to being a more intuitive ordering, this is easier to
programatically work with, because iterating through the ranges reaches
each one in the order of the versions it contains.

R=rnystrom@google.com

Committed: https://github.com/dart-lang/pub_semver/commit/ad0bed1e55290937e8e67c1ee2ab99101f1718f4

[Bob Nystrom, 2016-06-03 16:18:03]

https://codereview.chromium.org/2035983002/diff/1/lib/src/version.dart
File lib/src/version.dart (right):

https://codereview.chromium.org/2035983002/diff/1/lib/src/version.dart#newcode17
lib/src/version.dart:17: class Version implements VersionConstraint,
VersionRange {
Can this implement Comparable<VersionRange>?

https://codereview.chromium.org/2035983002/diff/1/lib/src/version.dart#newcod...
lib/src/version.dart:271: if (other is Version) {
Might be a bit simpler to do the negative test:

if (other is! Version) return -other.compareTo(this);

https://codereview.chromium.org/2035983002/diff/1/test/version_range_test.dart
File test/version_range_test.dart (right):

https://codereview.chromium.org/2035983002/diff/1/test/version_range_test.dar...
test/version_range_test.dart:485: new VersionRange(max: v010, includeMin: true),
What's the difference between this and the previous test? Doesn't not having a
minimum imply "includeMin"? What would an exclusive min mean if there is no
minimum?

[nweiz, 2016-06-06 22:27:46]

https://codereview.chromium.org/2035983002/diff/1/lib/src/version.dart
File lib/src/version.dart (right):

https://codereview.chromium.org/2035983002/diff/1/lib/src/version.dart#newcode17
lib/src/version.dart:17: class Version implements VersionConstraint,
VersionRange {
On 2016/06/03 16:18:03, Bob Nystrom wrote:
> Can this implement Comparable<VersionRange>?

It already does, transitively through VersionRange.

https://codereview.chromium.org/2035983002/diff/1/lib/src/version.dart#newcod...
lib/src/version.dart:271: if (other is Version) {
On 2016/06/03 16:18:03, Bob Nystrom wrote:
> Might be a bit simpler to do the negative test:
> 
> if (other is! Version) return -other.compareTo(this);

https://github.com/dart-lang/sdk/issues/25565 :(

https://codereview.chromium.org/2035983002/diff/1/test/version_range_test.dart
File test/version_range_test.dart (right):

https://codereview.chromium.org/2035983002/diff/1/test/version_range_test.dar...
test/version_range_test.dart:485: new VersionRange(max: v010, includeMin: true),
On 2016/06/03 16:18:03, Bob Nystrom wrote:
> What's the difference between this and the previous test? Doesn't not having a
> minimum imply "includeMin"? What would an exclusive min mean if there is no
> minimum?

This *should* be the same as the last test, but VersionRange stores [includeMin]
as `true` or `false` even if [min] is `null`. This verifies that a different
boolean flag there doesn't affect the comparison.

[Bob Nystrom, 2016-06-06 22:48:37]

lgtm

[nweiz, 2016-06-06 22:59:08]

Description was changed from

==========
Make VersionRange implement Comparable.

This changes the ordering of ranges in a VersionUnion. It used to order
solely by the upper bound; it now orders by lower bound, then upper
bound. In addition to being a more intuitive ordering, this is easier to
programatically work with, because iterating through the ranges reaches
each one in the order of the versions it contains.

R=rnystrom@google.com
==========

to

==========
Make VersionRange implement Comparable.

This changes the ordering of ranges in a VersionUnion. It used to order
solely by the upper bound; it now orders by lower bound, then upper
bound. In addition to being a more intuitive ordering, this is easier to
programatically work with, because iterating through the ranges reaches
each one in the order of the versions it contains.

R=rnystrom@google.com

Committed:
https://github.com/dart-lang/pub_semver/commit/ad0bed1e55290937e8e67c1ee2ab99...
==========

[nweiz, 2016-06-06 22:59:11]

Committed patchset #1 (id:1) manually as
ad0bed1e55290937e8e67c1ee2ab99101f1718f4 (presubmit successful).