Don't run transformers unnecessarily during the load process.

Don't run transformers unnecessarily during the load process.

R=rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=34139

[nweiz, 2014-03-19 20:16:54]

I was hoping this would fix issue 17603. It doesn't, but it should be useful
anyway in terms of improving startup time.

[Bob Nystrom, 2014-03-19 20:48:23]

Couple of nits but LGTM.

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right):

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:95: // phase
uses a transformer defined in [package] itself, that transform
"transform" -> "transformer".

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/utils.dart:338: /// are vertices reachable from
the keys.
How about "a map where each key is a vertex and the value is the set of other
vertices directly reachable from the key"?

[nweiz, 2014-03-19 21:13:19]

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart (right):

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/barback/load_all_transformers.dart:95: // phase
uses a transformer defined in [package] itself, that transform
On 2014/03/19 20:48:24, Bob Nystrom wrote:
> "transform" -> "transformer".

Done.

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
File sdk/lib/_internal/pub/lib/src/utils.dart (right):

https://codereview.chromium.org/203383014/diff/20001/sdk/lib/_internal/pub/li...
sdk/lib/_internal/pub/lib/src/utils.dart:338: /// are vertices reachable from
the keys.
On 2014/03/19 20:48:24, Bob Nystrom wrote:
> How about "a map where each key is a vertex and the value is the set of other
> vertices directly reachable from the key"?

Done.

[nweiz, 2014-03-19 21:13:41]

Committed patchset #3 manually as r34139 (presubmit successful).