Issue 20335002: Fix dart2js and dart2dart buildbot breakage

Issue 20335002: Fix dart2js and dart2dart buildbot breakage (Closed)

Created:
7 years, 5 months ago by Cutch

Modified:
7 years, 5 months ago

Reviewers:
vsm, ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix dart2js and dart2dart buildbot breakage Committed: https://code.google.com/p/dart/source/detail?r=25476

Patch Set 1 #

Total comments: 3

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -7 lines)			Patch
	M	sdk/lib/typed_data/dart2js/typed_data_dart2js.dart	View		1 chunk	+2 lines, -1 line	3 comments	Download
	M	tests/lib/lib.status	View		1 chunk	+0 lines, -6 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Cutch

Committed patchset #1 manually as r25476 (presubmit successful).

7 years, 5 months ago (2013-07-25 15:58:50 UTC) #2

ahe

lgtm https://codereview.chromium.org/20335002/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/20335002/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode708 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:708: Float32x4List nativeList = list as Float32x4List; What is ...

7 years, 5 months ago (2013-07-25 17:51:49 UTC) #3

Cutch

https://codereview.chromium.org/20335002/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right): https://codereview.chromium.org/20335002/diff/1/sdk/lib/typed_data/dart2js/typed_data_dart2js.dart#newcode708 sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:708: Float32x4List nativeList = list as Float32x4List; On 2013/07/25 17:51:49, ...

7 years, 5 months ago (2013-07-25 17:53:52 UTC) #4

ahe

7 years, 5 months ago (2013-07-25 18:04:12 UTC) #5

Cutch

7 years, 5 months ago (2013-07-25 18:05:27 UTC) #6

Message was sent while issue was closed.

On 2013/07/25 18:04:12, ahe wrote:
>
https://codereview.chromium.org/20335002/diff/1/sdk/lib/typed_data/dart2js/ty...
> File sdk/lib/typed_data/dart2js/typed_data_dart2js.dart (right):
> 
>
https://codereview.chromium.org/20335002/diff/1/sdk/lib/typed_data/dart2js/ty...
> sdk/lib/typed_data/dart2js/typed_data_dart2js.dart:708: Float32x4List
nativeList
> = list as Float32x4List;
> On 2013/07/25 17:53:53, Cutch wrote:
> > On 2013/07/25 17:51:49, ahe wrote:
> > > What is the cast for?
> > 
> > It fixes the checked mode failure that was complaining that List does not
have
> a
> > _storage member.
> 
> That should be fixed by the assignment. Why the cast?

Yes, you're right the cast is not necessary.

Expand Messages | Collapse Messages