Issue 203313005: Add mips failures to status files.

Issue 203313005: Add mips failures to status files. (Closed)

Created:
6 years, 9 months ago by Bill Hesse

Modified:
6 years, 9 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add mips failures to status files. BUG=dartbug.com/17440 R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=33811

Patch Set 2 : #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
M	runtime/tests/vm/vm.status	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/co19/co19-runtime.status	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	tests/standalone/standalone.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/203313005/diff/40001/runtime/tests/vm/vm.status File runtime/tests/vm/vm.status (right): https://codereview.chromium.org/203313005/diff/40001/runtime/tests/vm/vm.status#newcode73 runtime/tests/vm/vm.status:73: cc/StaticNonNullSumCallCodegen: Crash, Pass # dartbug.com/17440 Is this really ...

6 years, 9 months ago (2014-03-18 16:10:12 UTC) #2

Bill Hesse

Committed patchset #2 manually as r33811 (presubmit successful).

6 years, 9 months ago (2014-03-18 16:20:44 UTC) #3

Bill Hesse

6 years, 9 months ago (2014-03-18 16:21:26 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/203313005/diff/40001/runtime/tests/vm/vm.status
File runtime/tests/vm/vm.status (right):

https://codereview.chromium.org/203313005/diff/40001/runtime/tests/vm/vm.stat...
runtime/tests/vm/vm.status:73: cc/StaticNonNullSumCallCodegen: Crash, Pass #
dartbug.com/17440
On 2014/03/18 16:10:12, kustermann wrote:
> Is this really flaky or is it a difference between release/debug?

It is really flaky on debug.  On release we have only seen crash.

https://codereview.chromium.org/203313005/diff/40001/runtime/tests/vm/vm.stat...
runtime/tests/vm/vm.status:76: cc/FindCodeObject: Skip # Takes more than 8
minutes, times out.
On 2014/03/18 16:10:12, kustermann wrote:
> Why should this take 8 minutes?
> 
> Please add the issue number of the "mips triaging bug" here.

It takes 1 minute in release mode.  On sim-mips it is really fast, and on intel.
 Added the triage issue.

Expand Messages | Collapse Messages