Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 2032903006: Stop implementing ChunkedConverter. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/crypto.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop implementing ChunkedConverter. This was deprecated in Dart 1.17, and its members were changed such that we can no longer implement it and be strong-mode clean. R=rnystrom@google.com Committed: https://github.com/dart-lang/crypto/commit/43328044039941f674eac311e22b23fec9ae56b0

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M CHANGELOG.md View 1 1 chunk +8 lines, -0 lines 2 comments Download
M lib/src/hash.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/hmac.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
nweiz
4 years, 6 months ago (2016-06-03 22:25:37 UTC) #1
nweiz
4 years, 6 months ago (2016-06-03 22:30:44 UTC) #5
Bob Nystrom
lgtm https://codereview.chromium.org/2032903006/diff/40001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2032903006/diff/40001/CHANGELOG.md#newcode5 CHANGELOG.md:5: ">=0.9.2 <3.0.0"`. How about a more explicit before-after? ...
4 years, 6 months ago (2016-06-03 22:35:56 UTC) #6
nweiz
https://codereview.chromium.org/2032903006/diff/40001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2032903006/diff/40001/CHANGELOG.md#newcode5 CHANGELOG.md:5: ">=0.9.2 <3.0.0"`. On 2016/06/03 22:35:56, Bob Nystrom wrote: > ...
4 years, 6 months ago (2016-06-03 22:37:38 UTC) #7
nweiz
4 years, 6 months ago (2016-06-03 22:37:57 UTC) #9
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
43328044039941f674eac311e22b23fec9ae56b0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698