Issue 203193007: Add a bit of logging.

Issue 203193007: Add a bit of logging. (Closed)

Created:
6 years, 9 months ago by Bob Nystrom

Modified:
6 years, 9 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org, keertip

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add a bit of logging. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=34096

Patch Set 2 : Revise. #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -3 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/barback/build_environment.dart	View	1	3 chunks	+6 lines, -2 lines	0 comments	Download
	M	sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart	View	1	3 chunks	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

Pub is flaking out in one of the Editor tests, and I'm not sure how. ...

6 years, 9 months ago (2014-03-19 00:51:29 UTC) #1

nweiz

lgtm https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart File sdk/lib/_internal/pub/lib/src/barback/build_environment.dart (right): https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart#newcode177 sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:177: log.fine("Unserving $rootDirectory"); Period? https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/src/barback/build_environment.dart#newcode360 sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:360: log.fine("Providing sources for ...

6 years, 9 months ago (2014-03-19 00:54:56 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r34096 (presubmit successful).

6 years, 9 months ago (2014-03-19 02:06:33 UTC) #3

Bob Nystrom

6 years, 9 months ago (2014-03-19 02:06:52 UTC) #4

Message was sent while issue was closed.

Thanks!

https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/build_environment.dart (right):

https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:177:
log.fine("Unserving $rootDirectory");
On 2014/03/19 00:54:56, nweiz wrote:
> Period?

Done.

https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/build_environment.dart:360:
log.fine("Providing sources for ${package.name}/$dir.");
On 2014/03/19 00:54:56, nweiz wrote:
> "${package.name}/$dir" -> "${package.name}|$dir"

Done.

https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/sr...
File sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart (right):

https://codereview.chromium.org/203193007/diff/1/sdk/lib/_internal/pub/lib/sr...
sdk/lib/_internal/pub/lib/src/barback/web_socket_api.dart:75: log.io("Web Socket
command: $data");
On 2014/03/19 00:54:56, nweiz wrote:
> Period?

Left it off to not accidentally appear to be part of the data.

Expand Messages | Collapse Messages