Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(999)

Issue 2031873006: Stop implementing ChunkedConverter. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/convert.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop implementing ChunkedConverter. This was deprecated in Dart 1.17, and its members were changed such that we can no longer implement it and be strong-mode clean. R=kevmoo@google.com Committed: https://github.com/dart-lang/convert/commit/92ac5f1c90e6c84aedc8549aa11c0c8cbf33fce5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -10 lines) Patch
M CHANGELOG.md View 1 chunk +8 lines, -0 lines 0 comments Download
M lib/src/hex/decoder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/hex/encoder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/percent/decoder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M lib/src/percent/encoder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 6 months ago (2016-06-03 22:01:57 UTC) #1
kevmoo
lgtm
4 years, 6 months ago (2016-06-03 22:25:44 UTC) #2
nweiz
4 years, 6 months ago (2016-06-03 22:28:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
92ac5f1c90e6c84aedc8549aa11c0c8cbf33fce5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698