Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Issue 20316002: dart:io | Fix handling of exceptions from onBadCertificate callback. (Closed)

Created:
7 years, 5 months ago by Bill Hesse
Modified:
7 years, 5 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

dart:io | Fix handling of exceptions from onBadCertificate callback. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=25519

Patch Set 1 #

Patch Set 2 : Improve formatting #

Patch Set 3 : try again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -78 lines) Patch
M runtime/bin/secure_socket.h View 2 chunks +3 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.cc View 2 chunks +10 lines, -6 lines 0 comments Download
M sdk/lib/io/secure_socket.dart View 3 chunks +9 lines, -4 lines 0 comments Download
M tests/standalone/io/raw_secure_server_socket_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
A tests/standalone/io/secure_bad_certificate_client.dart View 1 chunk +59 lines, -0 lines 0 comments Download
A tests/standalone/io/secure_bad_certificate_test.dart View 1 1 chunk +63 lines, -0 lines 0 comments Download
M tests/standalone/io/secure_server_socket_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
D tests/standalone/io/secure_socket_bad_certificate_test.dart View 1 chunk +0 lines, -61 lines 0 comments Download
M tests/standalone/io/secure_socket_renegotiate_test.dart View 1 2 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Bill Hesse
7 years, 5 months ago (2013-07-25 14:38:14 UTC) #1
Bill Hesse
Changed exception handling during handshakes, so exceptions are not wrapped in HandshakeException just because they ...
7 years, 5 months ago (2013-07-26 10:01:29 UTC) #2
Søren Gjesse
lgtm
7 years, 5 months ago (2013-07-26 12:14:12 UTC) #3
Bill Hesse
7 years, 5 months ago (2013-07-26 13:39:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r25519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698