Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2029263003: Make the VersionUnion class public. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub_semver@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the VersionUnion class public. This is the first of several pub_semver changes to support my solver work. R=rnystrom@google.com Committed: https://github.com/dart-lang/pub_semver/commit/cba43fab9e441b7f94214261bd2e65d2fb0645d2

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -100 lines) Patch
M CHANGELOG.md View 1 chunk +6 lines, -0 lines 0 comments Download
M lib/pub_semver.dart View 1 chunk +1 line, -0 lines 0 comments Download
M lib/src/version_constraint.dart View 1 2 chunks +39 lines, -2 lines 0 comments Download
M lib/src/version_range.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/version_union.dart View 1 4 chunks +56 lines, -95 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
nweiz
4 years, 6 months ago (2016-06-01 23:54:51 UTC) #1
nweiz
4 years, 6 months ago (2016-06-01 23:57:46 UTC) #2
Bob Nystrom
LGTM!
4 years, 6 months ago (2016-06-02 00:16:24 UTC) #3
nweiz
4 years, 6 months ago (2016-06-02 00:56:04 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
cba43fab9e441b7f94214261bd2e65d2fb0645d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698