Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2028853002: Properly handle HTTP hosted URLs. (Closed)

Created:
4 years, 6 months ago by nweiz
Modified:
4 years, 6 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/pub.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Properly handle HTTP hosted URLs. We used to be storing packages from HTTP hosted sources in directories named after the hostname. There was no distinction between a package from an HTTP source and an HTTPS source with the same name. This was contrary to the rest of pub's logic, which considered those different sources. Closes #1418 R=rnystrom@google.com Committed: https://github.com/dart-lang/pub/commit/20ddf7ceff52fd1a5c8a303fdc82b066a187a2f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M lib/src/source/hosted.dart View 8 chunks +23 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 6 months ago (2016-05-31 21:41:32 UTC) #1
Bob Nystrom
lgtm
4 years, 6 months ago (2016-05-31 22:15:16 UTC) #2
nweiz
4 years, 6 months ago (2016-05-31 22:25:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20ddf7ceff52fd1a5c8a303fdc82b066a187a2f2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698